Reuse stack states during decoding to optimize GC load#228
Merged
gfx merged 1 commit intomsgpack:mainfrom Jul 22, 2023
Merged
Conversation
Member
|
It totally makes sense. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey @gfx found optimisation that I've missed somehow 2 years ago :D
StackStates are constantly being created for each array or map parsed.
If for example we parse array with 10k objects inside, it will allocate 10001 stack states, but in reality we only need 2 allocations. Max amount of allocation equals the max depth of nested objects/arrays inside on payload.
I've run msgpack benchmark, but it didn't show any large improvements. But I think these tests can't show it because they are very short living and GC have no time to kick off.
Change is simple and can have meaningful impact of apps processing large amount of data.
Also unified stack state object creation with fields from both types created in one place should have impact on V8 optimisation pipeline, because now each object will have the same shape.