Allow moving the SelectedItemsAdder popup by a given offset#460
Open
JojiiOfficial wants to merge 1 commit intoncmpcpp:masterfrom
Open
Allow moving the SelectedItemsAdder popup by a given offset#460JojiiOfficial wants to merge 1 commit intoncmpcpp:masterfrom
JojiiOfficial wants to merge 1 commit intoncmpcpp:masterfrom
Conversation
Collaborator
|
Thanks. Perhaps it would be better to simply change popups to show centered relative to the active screen instead? |
Collaborator
|
Ping 👋 |
Author
|
This sounds absolutely reasonable. Although I'm not a C++ dev and don't have enough time right now to dig further into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the 'add selected to playlist' popup by a given value in percent on the X axis. Resolves potentially overlapping album art images (#437) in some configurations.
config entry:
selected_item_x_offset = <-100 to 100>Before
After