Decopling of the proxy and HTTP/2 modules, and related fun #1030
+29
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to enable other HTTP/2-backed modules, such as ngx_http_proxy_v2_module and ngx_http_grpc_module, standalone without requirement to enable ngx_http_v2_module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired mostly by a bogus requirement to enable ngx_http_v2_module
in order to configure "proxy_http_version 2;".
This becomes noticeable with a generic HTTP/2 upstream support,
which unlike gRPC is not bound to HTTP/2 on the client side.
The series mostly follows the previous huffman decoupling from ngx_http_v2_module.