Merge pull request #1245 from rcjsuen/optional-discover

implausible · web-flow · commit c1ef342ce7bb · 2019-03-04T11:49:09.000-07:00
`ceiling_dirs` parameter in `Repository.discover` is optional
diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json
@@ -3260,6 +3260,9 @@
             "isErrorCode": true
           },
           "args": {
+            "ceiling_dirs": {
+              "isOptional": true
+            },
             "out": {
               "isReturn": true,
               "isSelf": false,
diff --git a/test/tests/repository.js b/test/tests/repository.js
@@ -208,13 +208,23 @@ describe("Repository", function() {
     });
   });
 
-  it("can discover if a path is part of a repository", function() {
+  function discover(ceiling) {
     var testPath = path.join(reposPath, "lib", "util", "normalize_oid.js");
     var expectedPath = path.join(reposPath, ".git");
-    return NodeGit.Repository.discover(testPath, 0, "")
+    return NodeGit.Repository.discover(testPath, 0, ceiling)
       .then(function(foundPath) {
         assert.equal(expectedPath, foundPath);
       });
+  }
+
+  it("can discover if a path is part of a repository, null ceiling",
+      function() {
+    return discover(null);
+  });
+
+  it("can discover if a path is part of a repository, empty ceiling",
+      function() {
+    return discover("");
   });
 
   it("can create a repo using initExt", function() {
