Expose error code in Status.file#1468
Merged
implausible merged 1 commit intonodegit:masterfrom Apr 6, 2018
Merged
Conversation
Due to a structural mistake in descriptor.json, Status.file does not expose git_status_file's error code in the rejected promise. The fix is the correct the JSON and also add a test to ensure that this case is covered should it happen again in the future. Signed-off-by: Remy Suen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change I made for #1467 helped me discover an error in our wrapper for
git_status_file. It seems likeStatus.filedoes not actually expose the C function's error code when an error occurs. I've fixed the descriptor and also added a test to hopefully ensure that this won't happen again in the future.