Skip to content

node-pre-gyp -> @mapbox/node-pre-gyp#1866

Closed
samuela wants to merge 1 commit intonodegit:masterfrom
samuela:samuela/node-pre-gyp
Closed

node-pre-gyp -> @mapbox/node-pre-gyp#1866
samuela wants to merge 1 commit intonodegit:masterfrom
samuela:samuela/node-pre-gyp

Conversation

@samuela
Copy link
Contributor

@samuela samuela commented Oct 14, 2021

The node-pre-gyp has been deprecated, moving to @mapbox/node-pre-gyp instead. See here and here for more info.

Built successfully and all tests pass.

@marvindanig marvindanig mentioned this pull request Oct 22, 2021
Open
@rcjsuen rcjsuen mentioned this pull request Oct 25, 2021
Closed
@jmurzy
Copy link
Contributor

jmurzy commented Nov 19, 2021

How can we get this into the next v28-alpha release?

@jfirebaugh
Copy link

jfirebaugh commented Feb 7, 2022

There was a breaking change in 1.0.0 that affects the GitHub action

no longer supporting node_pre_gyp_accessKeyId & node_pre_gyp_secretAccessKey, use AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY instead to authenticate against s3 for info, publish, and unpublish commands.

This code will need to be updated:

nodegit/.github/workflows/tests.yml

Lines 69 to 71 in bae468c

node_pre_gyp_bucket: ${{ secrets.node_pre_gyp_bucket }}
node_pre_gyp_accessKeyId: ${{ secrets.node_pre_gyp_accessKeyId }}
node_pre_gyp_secretAccessKey: ${{ secrets.node_pre_gyp_secretAccessKey }}

And similarly for macOS and Windows.

@ianhattendorf
Copy link
Member

ianhattendorf commented Feb 10, 2022 •
edited
Loading

Is node-pre-gyp causing issues for anyone right now? I understand it's deprecated, but we have quite a bit on our backlog so if it's not broken we'll prioritize other tasks over updating packages that are still functioning. Thanks for the PR though! It's just there's a good amount of verification necessary when touching the build system.

@samuela
Copy link
Contributor Author

samuela commented Feb 10, 2022

This was a while ago so I don't remember what is/was breaking, but node-pre-gyp has been deprecated for over a year now. Prioritization is ofc up to maintainers tho.

@julianmesa-gitkraken julianmesa-gitkraken mentioned this pull request Mar 17, 2022
Merged
@ianhattendorf
Copy link
Member

ianhattendorf commented Mar 17, 2022

This was handled alongside #1897, but thanks for bringing this to our attention!

@samuela samuela deleted the samuela/node-pre-gyp branch March 17, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samuela @jmurzy @jfirebaugh @ianhattendorf