Skip to content

Commit af689a4

Browse files
mertcanaltinmertcanaltin
committed
sync
1 parent 1640aeb commit af689a4

File tree

1,038 files changed

+4335
-6113
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,038 files changed

+4335
-6113
lines changed

‎.github/ISSUE_TEMPLATE/1-bug-report.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ body:
3333
label: How often does it reproduce? Is there a required condition?
3434
- type: textarea
3535
attributes:
36-
label: What is the expected behavior? Why is that the expected behavior?
36+
label: What is the expected behavior?
3737
description: If possible please provide textual output instead of screenshots.
3838
- type: textarea
3939
attributes:

‎.github/workflows/daily-wpt-fyi.yml‎

Lines changed: 17 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -81,74 +81,34 @@ jobs:
8181
clean: false
8282
ref: ${{ env.WPT_REVISION }}
8383

84-
# Node.js WPT Runner
8584
- name: Run WPT and generate report
85+
run: make test-wpt-report || true
86+
- name: Clone report for upload
8687
run: |
87-
make test-wpt-report || true
8888
if [ -e out/wpt/wptreport.json ]; then
89-
echo "WPT_REPORT=$(pwd)/out/wpt/wptreport.json" >> $GITHUB_ENV
89+
cd out/wpt
90+
cp wptreport.json wptreport-${{ steps.setup-node.outputs.node-version }}.json
9091
fi
91-
92-
# undici WPT Runner
93-
- name: Set env.UNDICI_VERSION
94-
if: ${{ env.WPT_REPORT != '' }}
95-
run: echo "UNDICI_VERSION=v$(jq -r '.version' < deps/undici/src/package.json)" >> $GITHUB_ENV
96-
- name: Remove deps/undici
97-
if: ${{ env.WPT_REPORT != '' }}
98-
run: rm -rf deps/undici
99-
- name: Checkout undici
100-
if: ${{ env.WPT_REPORT != '' }}
101-
uses: actions/checkout@v3
102-
with:
103-
repository: nodejs/undici
104-
persist-credentials: false
105-
path: deps/undici
106-
clean: false
107-
ref: ${{ env.UNDICI_VERSION }}
108-
- name: Add undici WPTs to the report
109-
if: ${{ env.WPT_REPORT != '' }}
110-
run: |
111-
rm -rf test/wpt/tests
112-
mv ../../test/fixtures/wpt/ test/wpt/tests/
113-
npm install
114-
npm run test:wpt || true
115-
working-directory: deps/undici
116-
117-
# Upload artifacts
118-
- name: Clone report for upload
119-
if: ${{ env.WPT_REPORT != '' }}
120-
working-directory: out/wpt
121-
run: cp wptreport.json wptreport-${{ steps.setup-node.outputs.node-version }}.json
12292
- name: Upload GitHub Actions artifact
123-
if: ${{ env.WPT_REPORT != '' }}
12493
uses: actions/upload-artifact@v3
12594
with:
12695
path: out/wpt/wptreport-*.json
12796
name: WPT Reports
128-
if-no-files-found: error
97+
if-no-files-found: warn
12998
- name: Upload WPT Report to wpt.fyi API
130-
if: ${{ env.WPT_REPORT != '' }}
13199
env:
132100
WPT_FYI_USERNAME: ${{ vars.WPT_FYI_USERNAME }}
133101
WPT_FYI_PASSWORD: ${{ secrets.WPT_FYI_PASSWORD }}
134-
working-directory: out/wpt
135102
run: |
136-
gzip wptreport.json
137-
echo "## Node.js ${{ steps.setup-node.outputs.node-version }}" >> $GITHUB_STEP_SUMMARY
138-
for WPT_FYI_ENDPOINT in "https://wpt.fyi/api/results/upload" "https://staging.wpt.fyi/api/results/upload"
139-
do
140-
response=$(curl -sS \
141-
-u "$WPT_FYI_USERNAME:$WPT_FYI_PASSWORD" \
142-
-F "[email protected]" \
143-
-F "labels=master" \
144-
$WPT_FYI_ENDPOINT)
145-
146-
if [[ $response =~ Task\ ([0-9]+)\ added\ to\ queue ]]; then
147-
run_id=${BASH_REMATCH[1]}
148-
origin=${WPT_FYI_ENDPOINT%/api/results/upload}
149-
150-
echo "" >> $GITHUB_STEP_SUMMARY
151-
echo "Run ID [$run_id]($origin/api/runs/$run_id) added to the processor queue at $origin" >> $GITHUB_STEP_SUMMARY
152-
echo "- [View on the ${origin:8} dashboard]($origin/results?run_id=$run_id)" >> $GITHUB_STEP_SUMMARY
153-
fi
154-
done
103+
if [ -e out/wpt/wptreport.json ]; then
104+
cd out/wpt
105+
gzip wptreport.json
106+
for WPT_FYI_ENDPOINT in "https://wpt.fyi/api/results/upload" "https://staging.wpt.fyi/api/results/upload"
107+
do
108+
curl \
109+
-u "$WPT_FYI_USERNAME:$WPT_FYI_PASSWORD" \
110+
-F "[email protected]" \
111+
-F "labels=master" \
112+
$WPT_FYI_ENDPOINT
113+
done
114+
fi

‎.github/workflows/find-inactive-tsc.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Find inactive TSC voting members
1+
name: Find inactive TSC members
22

33
on:
44
schedule:
@@ -38,7 +38,7 @@ jobs:
3838
with:
3939
node-version: ${{ env.NODE_VERSION }}
4040

41-
- name: Find inactive TSC voting members
41+
- name: Find inactive TSC members
4242
run: tools/find-inactive-tsc.mjs >> $GITHUB_ENV
4343

4444
- name: Open pull request
@@ -56,6 +56,6 @@ jobs:
5656
@nodejs/tsc ${{ env.INACTIVE_TSC_HANDLES }}
5757
5858
${{ env.DETAILS_FOR_COMMIT_BODY }}
59-
commit-message: 'meta: move TSC voting member(s) to regular member(s)'
59+
commit-message: 'meta: move one or more TSC members to emeritus'
6060
labels: meta
61-
title: 'meta: move TSC voting member(s) to regular member(s)'
61+
title: 'meta: move one or more TSC members to emeritus'

‎.github/workflows/tools.yml‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,12 @@ jobs:
134134
subsystem: deps
135135
label: dependencies
136136
run: |
137-
./tools/dep_updaters/update-ada.sh > temp-output
138-
cat temp-output
139-
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
140-
rm temp-output
137+
NEW_VERSION=$(gh api repos/ada-url/ada/releases/latest -q '.tag_name|ltrimstr("v")')
138+
CURRENT_VERSION=$(grep "#define ADA_VERSION" ./deps/ada/ada.h | sed -n "s/^.*VERSION \(.*\)/\1/p")
139+
if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
140+
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
141+
./tools/dep_updaters/update-ada.sh "$NEW_VERSION"
142+
fi
141143
- id: nghttp2
142144
subsystem: deps
143145
label: dependencies

‎CHANGELOG.md‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ release.
3535
</tr>
3636
<tr>
3737
<td valign="top">
38-
<b><a href="doc/changelogs/CHANGELOG_V19.md#19.8.1">19.8.1</a></b><br/>
39-
<a href="doc/changelogs/CHANGELOG_V19.md#19.8.0">19.8.0</a><br/>
40-
<a href="doc/changelogs/CHANGELOG_V19.md#19.7.0">19.7.0</a><br/>
38+
<b><a href="doc/changelogs/CHANGELOG_V19.md#19.7.0">19.7.0</a></b><br/>
4139
<a href="doc/changelogs/CHANGELOG_V19.md#19.6.1">19.6.1</a><br/>
4240
<a href="doc/changelogs/CHANGELOG_V19.md#19.6.0">19.6.0</a><br/>
4341
<a href="doc/changelogs/CHANGELOG_V19.md#19.5.0">19.5.0</a><br/>

‎GOVERNANCE.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ the issue tracker is:
118118

119119
* A TSC member opens an issue explaining the proposal/issue and @-mentions
120120
@nodejs/tsc.
121-
* The proposal passes if, after 72 hours, there are two or more TSC voting
122-
member approvals and no TSC voting member opposition.
121+
* The proposal passes if, after 72 hours, there are two or more TSC approvals
122+
and no TSC opposition.
123123
* If there is an extended impasse, a TSC member may make a motion for a vote.
124124

125125
## Collaborator nominations

‎README.md‎

Lines changed: 19 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,6 @@ For information about the governance of the Node.js project, see
158158

159159
### TSC (Technical Steering Committee)
160160

161-
#### TSC voting members
162-
163161
<!--lint disable prohibited-strings-->
164162

165163
* [aduh95](https://github.com/aduh95) -
@@ -176,6 +174,8 @@ For information about the governance of the Node.js project, see
176174
**Colin Ihrig** <<[email protected]>> (he/him)
177175
* [danielleadams](https://github.com/danielleadams) -
178176
**Danielle Adams** <<[email protected]>> (she/her)
177+
* [fhinkel](https://github.com/fhinkel) -
178+
**Franziska Hinkelmann** <<[email protected]>> (she/her)
179179
* [GeoffreyBooth](https://github.com/geoffreybooth) -
180180
**Geoffrey Booth** <<[email protected]>> (he/him)
181181
* [gireeshpunathil](https://github.com/gireeshpunathil) -
@@ -205,41 +205,28 @@ For information about the governance of the Node.js project, see
205205
* [Trott](https://github.com/Trott) -
206206
**Rich Trott** <<[email protected]>> (he/him)
207207

208-
#### TSC regular members
208+
<details>
209+
210+
<summary>Emeriti</summary>
211+
212+
### TSC emeriti
209213

210214
* [addaleax](https://github.com/addaleax) -
211215
**Anna Henningsen** <<[email protected]>> (she/her)
212216
* [bnoordhuis](https://github.com/bnoordhuis) -
213217
**Ben Noordhuis** <<[email protected]>>
218+
* [chrisdickinson](https://github.com/chrisdickinson) -
219+
**Chris Dickinson** <<[email protected]>>
214220
* [codebytere](https://github.com/codebytere) -
215221
**Shelley Vohr** <<[email protected]>> (she/her)
216222
* [danbev](https://github.com/danbev) -
217223
**Daniel Bevenius** <<[email protected]>> (he/him)
218-
* [fhinkel](https://github.com/fhinkel) -
219-
**Franziska Hinkelmann** <<[email protected]>> (she/her)
220-
* [gabrielschulhof](https://github.com/gabrielschulhof) -
221-
**Gabriel Schulhof** <<[email protected]>>
222-
* [mscdex](https://github.com/mscdex) -
223-
**Brian White** <<[email protected]>>
224-
* [MylesBorins](https://github.com/MylesBorins) -
225-
**Myles Borins** <<[email protected]>> (he/him)
226-
* [rvagg](https://github.com/rvagg) -
227-
**Rod Vagg** <<[email protected]>>
228-
* [TimothyGu](https://github.com/TimothyGu) -
229-
**Tiancheng "Timothy" Gu** <<[email protected]>> (he/him)
230-
231-
<details>
232-
233-
<summary>TSC emeriti members</summary>
234-
235-
#### TSC emeriti members
236-
237-
* [chrisdickinson](https://github.com/chrisdickinson) -
238-
**Chris Dickinson** <<[email protected]>>
239224
* [evanlucas](https://github.com/evanlucas) -
240225
**Evan Lucas** <<[email protected]>> (he/him)
241226
* [Fishrock123](https://github.com/Fishrock123) -
242227
**Jeremiah Senkpiel** <<[email protected]>> (he/they)
228+
* [gabrielschulhof](https://github.com/gabrielschulhof) -
229+
**Gabriel Schulhof** <<[email protected]>>
243230
* [gibfahn](https://github.com/gibfahn) -
244231
**Gibson Fahnestock** <<[email protected]>> (he/him)
245232
* [indutny](https://github.com/indutny) -
@@ -250,6 +237,10 @@ For information about the governance of the Node.js project, see
250237
**Josh Gavant** <<[email protected]>>
251238
* [mmarchini](https://github.com/mmarchini) -
252239
**Mary Marchini** <<[email protected]>> (she/her)
240+
* [mscdex](https://github.com/mscdex) -
241+
**Brian White** <<[email protected]>>
242+
* [MylesBorins](https://github.com/MylesBorins) -
243+
**Myles Borins** <<[email protected]>> (he/him)
253244
* [nebrius](https://github.com/nebrius) -
254245
**Bryan Hughes** <<[email protected]>>
255246
* [ofrobots](https://github.com/ofrobots) -
@@ -258,12 +249,16 @@ For information about the governance of the Node.js project, see
258249
**Alexis Campailla** <<[email protected]>>
259250
* [piscisaureus](https://github.com/piscisaureus) -
260251
**Bert Belder** <<[email protected]>>
252+
* [rvagg](https://github.com/rvagg) -
253+
**Rod Vagg** <<[email protected]>>
261254
* [sam-github](https://github.com/sam-github) -
262255
**Sam Roberts** <<[email protected]>>
263256
* [shigeki](https://github.com/shigeki) -
264257
**Shigeki Ohtsu** <<[email protected]>> (he/him)
265258
* [thefourtheye](https://github.com/thefourtheye) -
266259
**Sakthipriyan Vairamani** <<[email protected]>> (he/him)
260+
* [TimothyGu](https://github.com/TimothyGu) -
261+
**Tiancheng "Timothy" Gu** <<[email protected]>> (he/him)
267262
* [trevnorris](https://github.com/trevnorris) -
268263
**Trevor Norris** <<[email protected]>>
269264

‎benchmark/url/url-searchparams-creation.js‎

Lines changed: 0 additions & 79 deletions
This file was deleted.

0 commit comments

Comments
 (0)