Build, warning, header, and include fixes#10139
Closed
brody2consult wants to merge 15 commits intonodejs:masterfrom
Closed
Build, warning, header, and include fixes#10139brody2consult wants to merge 15 commits intonodejs:masterfrom
brody2consult wants to merge 15 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX [macOS]; Linux i386 & amd64) andvcbuild test nosign(.\vcbuild.bat nosignthen.\vcbuild.bat test nosign nobuildas Administrator on Windows) PASS OKAdditional item
Affected core subsystem(s)
build, crypto, dtrace, url, tls, other src
Description of change
General:
vcbuild(withnoperfctrand newwithout-inspector/without-profileroptions), Ubuntu Linux (i386/amd64), and macOSNODE_WANT_INTERNALSand extra includesThis PR includes the changes I originally raised in #9757 & #9767.
Details of proposed changes:
--without-profileroption to build with code related tov8-profiler.hdisabledvcbuild.bataddwithout-inspector&without-profileroptionsurl,crypto,dtrace,tls, and othersrcfixes to resolve warnings insrcon macOS, Ubuntu Linux (i386), and Windows buildsDecodeBytes&DecodeWriteto return portableptrdiff_ttype according to TODO note by @tjfontainenode.h: remove conditional includenode_internals.h, remove break innodenamespace, etc.NODE_WANT_INTERNALSfromsrcandnode.gypfilessrcfilesOther notes:
.\vcbuild.bat nosign noperfctr without-inspector without-profilerbuilds with zero warnings insrcon Windows with these changes.-WconversionI get a bunch of conversion warnings, even with the changes proposed here.// TBD POSSIBLE DATA LOSS:since I think we should examine these conversions at some point. I would be happy to take some or all of these out if necessary.I put all of these changes together since I think they are indirectly related and think they should be kept in the order proposed here. I kept the
cryptoandtlschanges in separately marked commits. I would be happy to split this into multiple PRs as long as they are not merged out of order. I would also be happy to squash some of the commits and rebase if necessary.TBD items for FUTURE consideration:
CPPLINT_EXCLUDE += src/queue.h(no longer there)testsrc/tree.h to adeps` subdirectory (easier way to exclude it from cpplint)src/node_root_certs.hto a special subdirectorysrc)