Skip to content

test: add coverage for child_process bounds check#11800

Closed
Trott wants to merge 3 commits intonodejs:masterfrom
Trott:index-check
Closed

test: add coverage for child_process bounds check#11800
Trott wants to merge 3 commits intonodejs:masterfrom
Trott:index-check

Conversation

@Trott
Copy link
Copy Markdown
Member

@Trott Trott commented Mar 11, 2017

Make sure that monkey-patching process.execArgv doesn't cause
child_process to incorrectly munge execArgv in fork().

This basically is adding coverage for an index > 0 check (see comment
in this commit). Previously, that condition was never false in any of
the tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test child_process

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants