Skip to content

test: fix flaky test-tls-socket-close #11921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 7 commits into from
Closed

test: fix flaky test-tls-socket-close #11921

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5db57ca
test: fix flaky test-tls-socket-close
Trott Mar 19, 2017
975a9bd
squash: fix test
Trott Mar 19, 2017
139685d
squash: fix lint
Trott Mar 19, 2017
97508b4
squash: more events, no timers
Trott Mar 19, 2017
83cc066
squash: hopefully this will do it
Trott Mar 19, 2017
553b9f8
squash: cleanup
Trott Mar 19, 2017
8056fcc
squash: comment update
Trott Mar 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: more events, no timers
  • Loading branch information
@Trott
Trott committed Mar 19, 2017
commit 97508b4f8f6e6656c4f02bcec4ebbae8fb1ab6b0
4 changes: 3 additions & 1 deletion test/parallel/test-tls-socket-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ const key = fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem');
const cert = fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem');

let tlsSocket;
let interval;
// tls server
const tlsServer = tls.createServer({ cert, key }, (socket) => {
tlsSocket = socket;
socket.on('error', common.mustCall((error) => {
assert.strictEqual(error.code, 'EINVAL');
tlsServer.close();
netServer.close();
clearInterval(interval);
}));
});

Expand All @@ -39,7 +41,7 @@ const netServer = net.createServer((socket) => {
assert(tlsSocket);
// this breaks if TLSSocket is already managing the socket:
netSocket.destroy();
setTimeout(() => { tlsSocket.write('bar'); }, 2);
netSocket.on('close', () => { tlsSocket.write('bar'); });
}));
}));
}));