Skip to content

Crypto add opensslerror stack#15518

Closed
gla5001 wants to merge 8 commits intonodejs:masterfrom
gla5001:crypto-add-opensslerror-stack
Closed

Crypto add opensslerror stack#15518
gla5001 wants to merge 8 commits intonodejs:masterfrom
gla5001:crypto-add-opensslerror-stack

Conversation

@gla5001
Copy link
Copy Markdown
Contributor

@gla5001 gla5001 commented Sep 21, 2017

Feature request to add openSSL error stack to the exception object
thrown from crypto. New exception property only added to object
if the error stack has not cleared out prior to calling
ThrowCryptoError.

I did something very wrong when trying to rebase, so i just created a new branch and a new PR. This PR has all the changes requested from #14725. I will close the other one.

Refs: #5444

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants