Skip to content

test: Z lib const descriptive failure messages #15977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlecHFerguson wants to merge 3 commits into from
Closed

test: Z lib const descriptive failure messages #15977

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44b59d2
zlib: more informative test failure messages
alec-ferguson-ck Oct 6, 2017
5f374a8
prettifying the code
alec-ferguson-ck Oct 6, 2017
1d7904c
fixed line length lints
alec-ferguson-ck Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
prettifying the code
  • Loading branch information
@alec-ferguson-ck
alec-ferguson-ck committed Oct 6, 2017
commit 5f374a87736601ecef60f1e64423b17bf8fc8885
17 changes: 11 additions & 6 deletions test/parallel/test-zlib-const.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,20 @@ const assert = require('assert');

const zlib = require('zlib');

assert.strictEqual(zlib.constants.Z_OK, 0, `Expected Z_OK to be 0; got ${zlib.constants.Z_OK}`);
assert.strictEqual(zlib.constants.Z_OK, 0,
`Expected Z_OK to be 0; got ${zlib.constants.Z_OK}`);
zlib.constants.Z_OK = 1;
assert.strictEqual(zlib.constants.Z_OK, 0, `Z_OK should be immutable. Expected to get 0, got ${zlib.constants.Z_OK}`);
assert.strictEqual(zlib.constants.Z_OK, 0,
`Z_OK should be immutable. Expected to get 0, got ${zlib.constants.Z_OK}`);

assert.strictEqual(zlib.codes.Z_OK, 0, `Expected Z_OK to be 0; got ${zlib.codes.Z_OK}`);
assert.strictEqual(zlib.codes.Z_OK, 0,
`Expected Z_OK to be 0; got ${zlib.codes.Z_OK}`);
zlib.codes.Z_OK = 1;
assert.strictEqual(zlib.codes.Z_OK, 0, `Z_OK should be immutable. Expected to get 0, got ${zlib.codes.Z_OK}`);
assert.strictEqual(zlib.codes.Z_OK, 0,
`Z_OK should be immutable. Expected to get 0, got ${zlib.codes.Z_OK}`);
zlib.codes = { Z_OK: 1 };
assert.strictEqual(zlib.codes.Z_OK, 0, `Z_OK should be immutable. Expected to get 0, got ${zlib.codes.Z_OK}`);
assert.strictEqual(zlib.codes.Z_OK, 0,
`Z_OK should be immutable. Expected to get 0, got ${zlib.codes.Z_OK}`);

assert.ok(Object.isFrozen(zlib.codes),
`Expected zlib.codes to be frozen, but Object.isFrozen returned ${Object.isFrozen(zlib.codes)}`);
`Expected zlib.codes to be frozen, but Object.isFrozen returned ${Object.isFrozen(zlib.codes)}`);