doc: include null as a return value for require.resolve.paths()#18350
Closed
nephross wants to merge 1 commit intonodejs:masterfrom
Closed
doc: include null as a return value for require.resolve.paths()#18350nephross wants to merge 1 commit intonodejs:masterfrom
nephross wants to merge 1 commit intonodejs:masterfrom
Conversation
Update documentation of modules.md for require.resolve.paths() to include the possibillity of null as a return value if the request string given matches a core module name. Fixes: nodejs#18230
nodejs-github-bot
added
doc
|
|
||
| Returns an array containing the paths searched during resolution of `request`. | ||
| Returns an array containing the paths searched during resolution of `request` or | ||
| null if the `request` string references a core module, for example `http` or |
Contributor
There was a problem hiding this comment.
Maybe null -> `null`?
Contributor
Author
There was a problem hiding this comment.
should the mention of array and string also be highlighted then? I viewed all of those as the same, and since array and string were not highlighted in the previous version, I used that as a guide. Can for sure give them the treatment if it's considered needed.
Contributor
There was a problem hiding this comment.
I am also not sure: array and string may have a general meaning, while null is more strict. But let us wait what others think. I am OK with the current form as well)
vsemozhetbyt
approved these changes
Jan 24, 2018
Contributor
vsemozhetbyt
added
the
fast-track
cjihrig
approved these changes
Jan 24, 2018
jasnell
approved these changes
Jan 24, 2018
vsemozhetbyt
pushed a commit
that referenced
this pull request
Jan 24, 2018
Update documentation of modules.md for require.resolve.paths() to include the possibillity of null as a return value if the request string given matches a core module name. PR-URL: #18350 Fixes: #18230 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
Contributor
Author
|
@vsemozhetbyt Thank you too for the review and helping hands both on this and the other PR:) |
Update documentation of modules.md for require.resolve.paths()
to include the possibillity of null as a return value if
the request string given matches a core module name.
Fixes: #18230
Checklist
Affected core subsystem(s)
doc