Skip to content

test: make url-parse-invalid-input engine agnostic #21132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: make url-parse-invalid-input engine agnostic #21132

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e33c35
test: make url-parse-invalid-input engine agnostic
Trott Jun 4, 2018
5e41652
squash!
Trott Jun 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash!
  • Loading branch information
@Trott
Trott committed Jun 7, 2018
commit 5e4165252f1203b607187586e6a236b1f6749097
5 changes: 1 addition & 4 deletions test/parallel/test-url-parse-invalid-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,5 @@ assert.throws(() => { url.parse('http://%E0%A4%A@fail'); },

// The error should be from the JS engine and not from Node.js.
// JS engine errors do not have the `code` property.
if (e.code !== undefined)
return false;

return true;
return e.code === undefined;
});