Skip to content

Code and learn rollup 2 #23651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 6 commits into from
Closed

Code and learn rollup 2 #23651

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcd9729
Flip Assertion Arguments for make-callback/test.js
Oct 12, 2018
b5e8a72
src: remove delete MessagePort.prototype.hasRef;
Oct 12, 2018
ee9704d
readline: assert without the use of event listener
Oct 12, 2018
f8ca6d6
test: correctly order assertion arguments
sheminusminus Oct 12, 2018
724843a
test: swap actual and expected in assertions
yitongding Oct 12, 2018
99cdfb7
test: replace function with arrow function
yitongding Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
readline: assert without the use of event listener
  • Loading branch information
@Trott
Lian Li authored and Trott committed Oct 14, 2018
commit ee9704dd82b08df78c0974863b43562103c8068e
14 changes: 6 additions & 8 deletions test/parallel/test-readline-emit-keypress-events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,9 @@ stream.on('keypress', (s, k) => {

stream.write('foo');

process.on('exit', () => {
assert.deepStrictEqual(sequence, ['f', 'o', 'o']);
assert.deepStrictEqual(keys, [
{ sequence: 'f', name: 'f', ctrl: false, meta: false, shift: false },
{ sequence: 'o', name: 'o', ctrl: false, meta: false, shift: false },
{ sequence: 'o', name: 'o', ctrl: false, meta: false, shift: false }
]);
});
assert.deepStrictEqual(sequence, ['f', 'o', 'o']);
assert.deepStrictEqual(keys, [
{ sequence: 'f', name: 'f', ctrl: false, meta: false, shift: false },
{ sequence: 'o', name: 'o', ctrl: false, meta: false, shift: false },
{ sequence: 'o', name: 'o', ctrl: false, meta: false, shift: false }
]);