Skip to content

test: fix the arguments order in assert.strictEqual#24612

Closed
tottokotkd wants to merge 1 commit intonodejs:masterfrom
tottokotkd:feature/strictEqual-in-test-http-default-encoding
Closed

test: fix the arguments order in assert.strictEqual#24612
tottokotkd wants to merge 1 commit intonodejs:masterfrom
tottokotkd:feature/strictEqual-in-test-http-default-encoding

Conversation

@tottokotkd
Copy link
Copy Markdown
Contributor

@tottokotkd tottokotkd commented Nov 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+1 more reviewer

@Leko Leko Leko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tottokotkd @gireeshpunathil @addaleax @Leko @cjihrig @joyeecheung @BethGriggs @nodejs-github-bot