src: use internalBinding('config').hasInspector in JS land#25291
Closed
joyeecheung wants to merge 2 commits intonodejs:masterfrom
Closed
src: use internalBinding('config').hasInspector in JS land#25291joyeecheung wants to merge 2 commits intonodejs:masterfrom
internalBinding('config').hasInspector in JS land#25291joyeecheung wants to merge 2 commits intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
process.config.variables.v8_enable_inspectorwhich depends on the variable name in gyp files, or detecting
internalBinding('inspector').Connection.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes