Skip to content

build: enhance Python 3 compatibility#28537

Closed
cclauss wants to merge 8 commits intonodejs:masterfrom
cclauss:workspace
Closed

build: enhance Python 3 compatibility#28537
cclauss wants to merge 8 commits intonodejs:masterfrom
cclauss:workspace

Conversation

@cclauss
Copy link
Copy Markdown
Contributor

@cclauss cclauss commented Jul 4, 2019

CAUTION: This PR requires a pip install six adding the Node deps tools directory to PYTHONPATH so it should not be merged. six is contained in a single file and is very broadly used so this PR advocates that we add it to our dependencies.

Modify Python files used in the build process to get us closer to Python 3 compatibility. Based on lessons learned in #25878, this pull request (combined with #28555) would allow us to modify just .travis.yml and configure and get a significant way through the V8 and Node build processes on Python 3 in Travis CI.

In Python 2 mode (current state) it passes all the Travis CI tests but I will need advise on how to:

  1. Add pip install six to the Jenkins tests -- or --
  2. Add the six.py to our dependencies.
  3. Add the Node deps tools directory to PYTHONPATH in all the right places (especially on Windows)
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs/python

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants