build: enhance Python 3 compatibility#28537
Closed
cclauss wants to merge 8 commits intonodejs:masterfrom
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAUTION: This PR requires
a pip install sixadding the Nodedepstools directory to PYTHONPATH so it should not be merged. six is contained in a single file and is very broadly used so this PR advocates that we add it to our dependencies.Modify Python files used in the build process to get us closer to Python 3 compatibility. Based on lessons learned in #25878, this pull request (combined with #28555) would allow us to modify just .travis.yml and configure and get a significant way through the V8 and Node build processes on Python 3 in Travis CI.
In Python 2 mode (current state) it passes all the Travis CI tests but I will need advise on how to:
Add pip install six to the Jenkins tests -- or --Add the six.py to our dependencies.depstools directory to PYTHONPATH in all the right places (especially on Windows)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes@nodejs/python