Skip to content

docs: refine conditional exports documentation#32098

Closed
guybedford wants to merge 39 commits intomasterfrom
doc-exports-pattern
Closed

docs: refine conditional exports documentation#32098
guybedford wants to merge 39 commits intomasterfrom
doc-exports-pattern

Conversation

@guybedford
Copy link
Contributor

@guybedford guybedford commented Mar 4, 2020

This began as a bigger change of guidance but has been pulled back to a simple docs refactoring.

  • Moves exports sugar section up
  • Makes conditional exports examples using main form directly
  • Explains conditional exports sugar second
  • Adds some extra guidance on conditions usage
  • Cuts down on some unnecessary explanations to try aid readability
  • Removes incorrect statement about export main falling back to package.json main

Resolves #32107.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [] tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

package.exports: false is not working with module loader

7 participants