Skip to content

build: create separate rebuild-doc-addons target #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisdickinson wants to merge 1 commit into from
Closed

build: create separate rebuild-doc-addons target #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: create separate rebuild-doc-addons target 
this allows the build-addons target to "see" the
directories that verify-addons.js is creating, which
prevents errors in downstream targets on clean test runs.
  • Loading branch information
@chrisdickinson
chrisdickinson committed Jan 13, 2015
commit 55dd35b092fb31e9c09af4a011735d2c6e1ca4d2
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,11 @@ test/gc/node_modules/weak/build/Release/weakref.node: $(NODE_EXE)
--directory="$(shell pwd)/test/gc/node_modules/weak" \
--nodedir="$(shell pwd)"

build-addons: $(NODE_EXE)
rebuild-doc-addons: $(NODE_EXE)
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Jan 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, build-addons would take dependencies on the gyp and .cc files so that it only runs when something has changed.

rm -rf test/addons/doc-*/
./$(NODE_EXE) tools/doc/addon-verify.js

build-addons: rebuild-doc-addons
$(foreach dir, \
$(sort $(dir $(wildcard test/addons/*/*.gyp))), \
./$(NODE_EXE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
Expand Down