-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
v14.2.0 release proposal #33232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v14.2.0 release proposal #33232
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
c87ed21
assert: port common.mustCall() to assert
DavenportEmma 4423304
vm: throw error when duplicated exportNames in SyntheticModule
himself65 8c40ffc
tools: update broken types in type parser
cjihrig 8d5ac1b
wasi: rename __wasi_unstable_reactor_start()
cjihrig d7d9960
wasi: update start() behavior to match spec
cjihrig 8325c29
deps: update to uvwasi 0.0.8
cjihrig ed45b51
path: fix comment grammar
thecodrr ec24577
v8: use AliasedBuffers for passing heap statistics around
joyeecheung 542da43
lib: fix validateport error message when allowZero is false
rickyes aced1f5
test: flaky test-stdout-close-catch on freebsd
sam-github f79ef96
test: mark test flaky on freebsd
sam-github 3cb1713
http2,doc: minor fixes
mildsunrise db293c4
cluster: fix error on worker disconnect/destroy
santigimeno 637442f
crypto: key size must be int32 in DiffieHellman()
bnoordhuis e07cca6
crypto: generator must be int32 in DiffieHellman()
bnoordhuis 83e165b
crypto: check DiffieHellman p and g params
bnoordhuis c49e3ea
console: support console constructor groupIndentation option
rickyes 10a87c8
src: remove unnecessary fully qualified names
rickyes 12426f5
tools: update [email protected]
Trott c5a2f9a
doc: fix markdown parsing on doc/api/os.md
juanarbol 466213d
n-api: simplify uv_idle wrangling
bnoordhuis 82e459d
doc: don't check links in tmp dirs
bnoordhuis 92c7e06
test: check args on SourceTextModule cachedData
juanarbol b183d0a
stream: let Duplex re-use Writable properties
ronag 289a5c8
doc: some grammar fixes
ChrisAHolland de15edc
doc: improve worker pool example
ranjan-purbey 3c2f608
test: correct typo in test name
cjihrig c6d632a
worker: unify custom error creation
addaleax bc9e413
worker: add stack size resource limit option
addaleax bc40ed3
stream: add null check in Readable.from
rexagod 2396219
doc: correct Nodejs to Node.js spelling
nschonni 541ea03
src: separate out NgLibMemoryManagerBase
jasnell eab4be1
lib: cosmetic change to builtinLibs list for maintainability
jasnell f4e5ab1
src: crypto::UseSNIContext to use BaseObjectPtr
jasnell f61928b
src: return undefined when validation err == 0
jasnell 3866dc1
wasi: use free() to release preopen array
addaleax de643bc
src: use unique_ptr for CachedData in ContextifyScript::New
addaleax 9ccb6b2
test: add missing calls to napi_async_destroy
addaleax af7da46
test: fix out-of-bound reads from invalid sizeof usage
addaleax f62d92b
build: add --error-on-warn configure flag
danbev a87d371
tools: fix redundant-move warning in inspector
danbev 5eccf1e
module: no type module resolver side effects
guybedford 4cfa7e0
stream: simplify Readable push/unshift logic
himself65 d39254a
vm: fix vm.measureMemory() and introduce execution option
joyeecheung 45032a3
stream: fix stream.finished on Duplex
ronag 89ed7a5
test: move test-process-title to sequential
addaleax c5a4534
deps: V8: backport e29c62b74854
addaleax e276524
test: skip memory usage tests when ASAN is enabled
addaleax 451993e
http: set default timeout in agent keepSocketAlive
omsmith a990137
doc: fix the spelling error in stream.md
yunnysunny 36d5002
doc: clarify when not to run CI on docs
juanarbol d02ced8
doc: add util.types.isArrayBufferView()
kevinoid 6734cc4
tools: bump remark-preset-lint-node to 1.15.0
Trott bb2d2f6
src: remove unused v8 Message namespace
edsadr 7893bde
doc: fix a typo in crypto.generateKeyPairSync()
himself65 a4ec01c
http: simplify sending header
ronag 2174159
esm: improve commonjs hint on module not found
dnlup 413f5d3
doc: add missing deprecation not
ronag 60ebbc4
test: update c8 ignore comment
74b0e8c
http: ensure client request emits close
ronag 6925b35
doc: mark assert.CallTracker experimental
BridgeAR d68f78f
2020-05-05, Version 14.2.0 (Current)
targos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
2020-05-05, Version 14.2.0 (Current)
Notable changes: * Track function calls with `assert.CallTracker` (experimental). #31982 * Added a `groupIndentation` option to the `Console` constructor. #32964 PR-URL: #33232
- Loading branch information
commit d68f78f10b91d9f9bfd7a4017fa2b9b01f6df99b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ | |
| </tr> | ||
| <tr> | ||
| <td> | ||
| <a href="#14.2.0">14.2.0</a><br/> | ||
| <a href="#14.1.0">14.1.0</a><br/> | ||
| <a href="#14.0.0">14.0.0</a><br/> | ||
| </td> | ||
|
|
@@ -31,6 +32,169 @@ | |
| * [io.js](CHANGELOG_IOJS.md) | ||
| * [Archive](CHANGELOG_ARCHIVE.md) | ||
|
|
||
| <a id="14.2.0"></a> | ||
| ## 2020-05-05, Version 14.2.0 (Current), @targos | ||
|
|
||
| ### Notable Changes | ||
|
|
||
| #### Track function calls with `assert.CallTracker` (experimental) | ||
|
|
||
| `assert.CallTracker` is a new experimental API that allows to track and later | ||
| verify the number of times a function was called. This works by creating a | ||
| `CallTracker` object and using its `calls` method to create wrapper functions | ||
| that will count each time they are called. Then the `verify` method can be used | ||
| to assert that the expected number of calls happened: | ||
|
|
||
| ```js | ||
| const assert = require('assert'); | ||
|
|
||
| const tracker = new assert.CallTracker(); | ||
|
|
||
| function func() {} | ||
| // callsfunc() must be called exactly twice before tracker.verify(). | ||
| const callsfunc = tracker.calls(func, 2); | ||
| callsfunc(); | ||
| callsfunc(); | ||
|
|
||
| function otherFunc() {} | ||
| // The second parameter defaults to `1`. | ||
| const callsotherFunc = tracker.calls(otherFunc); | ||
| callsotherFunc(); | ||
|
|
||
| // Calls tracker.verify() and verifies if all tracker.calls() functions have | ||
| // been called the right number of times. | ||
| process.on('exit', () => { | ||
| tracker.verify(); | ||
| }); | ||
| ``` | ||
|
|
||
| Additionally, `tracker.report()` will return an array which contains information | ||
| about the errors, if there are any: | ||
|
|
||
| <!-- eslint-disable max-len --> | ||
| ```js | ||
| const assert = require('assert'); | ||
|
|
||
| const tracker = new assert.CallTracker(); | ||
|
|
||
| function func() {} | ||
| const callsfunc = tracker.calls(func); | ||
|
|
||
| console.log(tracker.report()); | ||
| /* | ||
| [ | ||
| { | ||
| message: 'Expected the func function to be executed 1 time(s) but was executed 0 time(s).', | ||
| actual: 0, | ||
| expected: 1, | ||
| operator: 'func', | ||
| stack: Error | ||
| ... | ||
| } | ||
| ] | ||
| */ | ||
| ``` | ||
|
|
||
| Contributed by ConorDavenport - [#31982](https://github.com/nodejs/node/pull/31982). | ||
|
|
||
| #### Console `groupIndentation` option | ||
|
|
||
| The Console constructor (`require('console').Console`) now supports different group indentations. | ||
|
|
||
| This is useful in case you want different grouping width than 2 spaces. | ||
|
|
||
| ```js | ||
| const { Console } = require('console'); | ||
| const customConsole = new Console({ | ||
| stdout: process.stdout, | ||
| stderr: process.stderr, | ||
| groupIndentation: 10 | ||
| }); | ||
|
|
||
| customConsole.log('foo'); | ||
| // 'foo' | ||
| customConsole.group(); | ||
| customConsole.log('foo'); | ||
| // 'foo' | ||
| ``` | ||
|
|
||
| Contributed by rickyes - [#32964](https://github.com/nodejs/node/pull/32964). | ||
|
|
||
| ### Commits | ||
|
|
||
| #### Semver-minor commits | ||
|
|
||
| * [[`c87ed21fdf`](https://github.com/nodejs/node/commit/c87ed21fdf)] - **(SEMVER-MINOR)** **assert**: port common.mustCall() to assert (ConorDavenport) [#31982](https://github.com/nodejs/node/pull/31982) | ||
| * [[`c49e3ea20c`](https://github.com/nodejs/node/commit/c49e3ea20c)] - **(SEMVER-MINOR)** **console**: support console constructor groupIndentation option (rickyes) [#32964](https://github.com/nodejs/node/pull/32964) | ||
| * [[`bc9e413dae`](https://github.com/nodejs/node/commit/bc9e413dae)] - **(SEMVER-MINOR)** **worker**: add stack size resource limit option (Anna Henningsen) [#33085](https://github.com/nodejs/node/pull/33085) | ||
|
|
||
| #### Semver-patch commits | ||
|
|
||
| * [[`f62d92b900`](https://github.com/nodejs/node/commit/f62d92b900)] - **build**: add --error-on-warn configure flag (Daniel Bevenius) [#32685](https://github.com/nodejs/node/pull/32685) | ||
| * [[`db293c47dd`](https://github.com/nodejs/node/commit/db293c47dd)] - **cluster**: fix error on worker disconnect/destroy (Santiago Gimeno) [#32793](https://github.com/nodejs/node/pull/32793) | ||
| * [[`83e165bf88`](https://github.com/nodejs/node/commit/83e165bf88)] - **crypto**: check DiffieHellman p and g params (Ben Noordhuis) [#32739](https://github.com/nodejs/node/pull/32739) | ||
| * [[`e07cca6af6`](https://github.com/nodejs/node/commit/e07cca6af6)] - **crypto**: generator must be int32 in DiffieHellman() (Ben Noordhuis) [#32739](https://github.com/nodejs/node/pull/32739) | ||
| * [[`637442fec9`](https://github.com/nodejs/node/commit/637442fec9)] - **crypto**: key size must be int32 in DiffieHellman() (Ben Noordhuis) [#32739](https://github.com/nodejs/node/pull/32739) | ||
| * [[`c5a4534d5c`](https://github.com/nodejs/node/commit/c5a4534d5c)] - **deps**: V8: backport e29c62b74854 (Anna Henningsen) [#33125](https://github.com/nodejs/node/pull/33125) | ||
| * [[`8325c29e92`](https://github.com/nodejs/node/commit/8325c29e92)] - **deps**: update to uvwasi 0.0.8 (Colin Ihrig) [#33078](https://github.com/nodejs/node/pull/33078) | ||
| * [[`2174159598`](https://github.com/nodejs/node/commit/2174159598)] - **esm**: improve commonjs hint on module not found (Daniele Belardi) [#31906](https://github.com/nodejs/node/pull/31906) | ||
| * [[`74b0e8c3a8`](https://github.com/nodejs/node/commit/74b0e8c3a8)] - **http**: ensure client request emits close (Robert Nagy) [#33178](https://github.com/nodejs/node/pull/33178) | ||
| * [[`a4ec01c55b`](https://github.com/nodejs/node/commit/a4ec01c55b)] - **http**: simplify sending header (Robert Nagy) [#33200](https://github.com/nodejs/node/pull/33200) | ||
| * [[`451993ea94`](https://github.com/nodejs/node/commit/451993ea94)] - **http**: set default timeout in agent keepSocketAlive (Owen Smith) [#33127](https://github.com/nodejs/node/pull/33127) | ||
| * [[`3cb1713a59`](https://github.com/nodejs/node/commit/3cb1713a59)] - **http2,doc**: minor fixes (Alba Mendez) [#28044](https://github.com/nodejs/node/pull/28044) | ||
| * [[`eab4be1b93`](https://github.com/nodejs/node/commit/eab4be1b93)] - **lib**: cosmetic change to builtinLibs list for maintainability (James M Snell) [#33106](https://github.com/nodejs/node/pull/33106) | ||
| * [[`542da430ff`](https://github.com/nodejs/node/commit/542da430ff)] - **lib**: fix validateport error message when allowZero is false (rickyes) [#32861](https://github.com/nodejs/node/pull/32861) | ||
| * [[`5eccf1e9ad`](https://github.com/nodejs/node/commit/5eccf1e9ad)] - **module**: no type module resolver side effects (Guy Bedford) [#33086](https://github.com/nodejs/node/pull/33086) | ||
| * [[`466213d726`](https://github.com/nodejs/node/commit/466213d726)] - **n-api**: simplify uv\_idle wrangling (Ben Noordhuis) [#32997](https://github.com/nodejs/node/pull/32997) | ||
| * [[`ed45b51642`](https://github.com/nodejs/node/commit/ed45b51642)] - **path**: fix comment grammar (thecodrr) [#32942](https://github.com/nodejs/node/pull/32942) | ||
| * [[`bb2d2f6e0e`](https://github.com/nodejs/node/commit/bb2d2f6e0e)] - **src**: remove unused v8 Message namespace (Adrian Estrada) [#33180](https://github.com/nodejs/node/pull/33180) | ||
| * [[`de643bc325`](https://github.com/nodejs/node/commit/de643bc325)] - **src**: use unique\_ptr for CachedData in ContextifyScript::New (Anna Henningsen) [#33113](https://github.com/nodejs/node/pull/33113) | ||
| * [[`f61928ba35`](https://github.com/nodejs/node/commit/f61928ba35)] - **src**: return undefined when validation err == 0 (James M Snell) [#33107](https://github.com/nodejs/node/pull/33107) | ||
| * [[`f4e5ab14da`](https://github.com/nodejs/node/commit/f4e5ab14da)] - **src**: crypto::UseSNIContext to use BaseObjectPtr (James M Snell) [#33107](https://github.com/nodejs/node/pull/33107) | ||
| * [[`541ea035bf`](https://github.com/nodejs/node/commit/541ea035bf)] - **src**: separate out NgLibMemoryManagerBase (James M Snell) [#33104](https://github.com/nodejs/node/pull/33104) | ||
| * [[`10a87c81cf`](https://github.com/nodejs/node/commit/10a87c81cf)] - **src**: remove unnecessary fully qualified names (rickyes) [#33077](https://github.com/nodejs/node/pull/33077) | ||
| * [[`45032a39e8`](https://github.com/nodejs/node/commit/45032a39e8)] - **stream**: fix stream.finished on Duplex (Robert Nagy) [#33133](https://github.com/nodejs/node/pull/33133) | ||
| * [[`4cfa7e0716`](https://github.com/nodejs/node/commit/4cfa7e0716)] - **stream**: simplify Readable push/unshift logic (himself65) [#32899](https://github.com/nodejs/node/pull/32899) | ||
| * [[`bc40ed31b3`](https://github.com/nodejs/node/commit/bc40ed31b3)] - **stream**: add null check in Readable.from (Pranshu Srivastava) [#32873](https://github.com/nodejs/node/pull/32873) | ||
| * [[`b183d0a18a`](https://github.com/nodejs/node/commit/b183d0a18a)] - **stream**: let Duplex re-use Writable properties (Robert Nagy) [#33079](https://github.com/nodejs/node/pull/33079) | ||
| * [[`ec24577406`](https://github.com/nodejs/node/commit/ec24577406)] - **v8**: use AliasedBuffers for passing heap statistics around (Joyee Cheung) [#32929](https://github.com/nodejs/node/pull/32929) | ||
| * [[`d39254ada6`](https://github.com/nodejs/node/commit/d39254ada6)] - **vm**: fix vm.measureMemory() and introduce execution option (Joyee Cheung) [#32988](https://github.com/nodejs/node/pull/32988) | ||
| * [[`4423304ac4`](https://github.com/nodejs/node/commit/4423304ac4)] - **vm**: throw error when duplicated exportNames in SyntheticModule (himself65) [#32810](https://github.com/nodejs/node/pull/32810) | ||
| * [[`3866dc1311`](https://github.com/nodejs/node/commit/3866dc1311)] - **wasi**: use free() to release preopen array (Anna Henningsen) [#33110](https://github.com/nodejs/node/pull/33110) | ||
| * [[`d7d9960d38`](https://github.com/nodejs/node/commit/d7d9960d38)] - **wasi**: update start() behavior to match spec (Colin Ihrig) [#33073](https://github.com/nodejs/node/pull/33073) | ||
| * [[`8d5ac1bbf0`](https://github.com/nodejs/node/commit/8d5ac1bbf0)] - **wasi**: rename \_\_wasi\_unstable\_reactor\_start() (Colin Ihrig) [#33073](https://github.com/nodejs/node/pull/33073) | ||
| * [[`c6d632a72a`](https://github.com/nodejs/node/commit/c6d632a72a)] - **worker**: unify custom error creation (Anna Henningsen) [#33084](https://github.com/nodejs/node/pull/33084) | ||
|
|
||
| #### Documentation commits | ||
|
|
||
| * [[`6925b358f9`](https://github.com/nodejs/node/commit/6925b358f9)] - **doc**: mark assert.CallTracker experimental (Ruben Bridgewater) [#33124](https://github.com/nodejs/node/pull/33124) | ||
| * [[`413f5d3581`](https://github.com/nodejs/node/commit/413f5d3581)] - **doc**: add missing deprecation not (Robert Nagy) [#33203](https://github.com/nodejs/node/pull/33203) | ||
| * [[`7893bde07e`](https://github.com/nodejs/node/commit/7893bde07e)] - **doc**: fix a typo in crypto.generateKeyPairSync() (himself65) [#33187](https://github.com/nodejs/node/pull/33187) | ||
| * [[`d02ced8af6`](https://github.com/nodejs/node/commit/d02ced8af6)] - **doc**: add util.types.isArrayBufferView() (Kevin Locke) [#33092](https://github.com/nodejs/node/pull/33092) | ||
| * [[`36d50027af`](https://github.com/nodejs/node/commit/36d50027af)] - **doc**: clarify when not to run CI on docs (Juan José Arboleda) [#33101](https://github.com/nodejs/node/pull/33101) | ||
| * [[`a99013718c`](https://github.com/nodejs/node/commit/a99013718c)] - **doc**: fix the spelling error in stream.md (白一梓) [#31561](https://github.com/nodejs/node/pull/31561) | ||
| * [[`23962191c1`](https://github.com/nodejs/node/commit/23962191c1)] - **doc**: correct Nodejs to Node.js spelling (Nick Schonning) [#33088](https://github.com/nodejs/node/pull/33088) | ||
| * [[`de15edcfc0`](https://github.com/nodejs/node/commit/de15edcfc0)] - **doc**: improve worker pool example (Ranjan Purbey) [#33082](https://github.com/nodejs/node/pull/33082) | ||
| * [[`289a5c8dfb`](https://github.com/nodejs/node/commit/289a5c8dfb)] - **doc**: some grammar fixes (Chris Holland) [#33081](https://github.com/nodejs/node/pull/33081) | ||
| * [[`82e459d9af`](https://github.com/nodejs/node/commit/82e459d9af)] - **doc**: don't check links in tmp dirs (Ben Noordhuis) [#32996](https://github.com/nodejs/node/pull/32996) | ||
| * [[`c5a2f9a02a`](https://github.com/nodejs/node/commit/c5a2f9a02a)] - **doc**: fix markdown parsing on doc/api/os.md (Juan José Arboleda) [#33067](https://github.com/nodejs/node/pull/33067) | ||
|
|
||
| #### Other commits | ||
|
|
||
| * [[`60ebbc4386`](https://github.com/nodejs/node/commit/60ebbc4386)] - **test**: update c8 ignore comment (Benjamin Coe) [#33151](https://github.com/nodejs/node/pull/33151) | ||
| * [[`e276524fcc`](https://github.com/nodejs/node/commit/e276524fcc)] - **test**: skip memory usage tests when ASAN is enabled (Anna Henningsen) [#33129](https://github.com/nodejs/node/pull/33129) | ||
| * [[`89ed7a5862`](https://github.com/nodejs/node/commit/89ed7a5862)] - **test**: move test-process-title to sequential (Anna Henningsen) [#33150](https://github.com/nodejs/node/pull/33150) | ||
| * [[`af7da46d9b`](https://github.com/nodejs/node/commit/af7da46d9b)] - **test**: fix out-of-bound reads from invalid sizeof usage (Anna Henningsen) [#33115](https://github.com/nodejs/node/pull/33115) | ||
| * [[`9ccb6b2e8c`](https://github.com/nodejs/node/commit/9ccb6b2e8c)] - **test**: add missing calls to napi\_async\_destroy (Anna Henningsen) [#33114](https://github.com/nodejs/node/pull/33114) | ||
| * [[`3c2f608a8d`](https://github.com/nodejs/node/commit/3c2f608a8d)] - **test**: correct typo in test name (Colin Ihrig) [#33083](https://github.com/nodejs/node/pull/33083) | ||
| * [[`92c7e0620f`](https://github.com/nodejs/node/commit/92c7e0620f)] - **test**: check args on SourceTextModule cachedData (Juan José Arboleda) [#32956](https://github.com/nodejs/node/pull/32956) | ||
| * [[`f79ef96fea`](https://github.com/nodejs/node/commit/f79ef96fea)] - **test**: mark test flaky on freebsd (Sam Roberts) [#32849](https://github.com/nodejs/node/pull/32849) | ||
| * [[`aced1f5d70`](https://github.com/nodejs/node/commit/aced1f5d70)] - **test**: flaky test-stdout-close-catch on freebsd (Sam Roberts) [#32849](https://github.com/nodejs/node/pull/32849) | ||
| * [[`6734cc43df`](https://github.com/nodejs/node/commit/6734cc43df)] - **tools**: bump remark-preset-lint-node to 1.15.0 (Rich Trott) [#33157](https://github.com/nodejs/node/pull/33157) | ||
| * [[`a87d371014`](https://github.com/nodejs/node/commit/a87d371014)] - **tools**: fix redundant-move warning in inspector (Daniel Bevenius) [#32685](https://github.com/nodejs/node/pull/32685) | ||
| * [[`12426f59f5`](https://github.com/nodejs/node/commit/12426f59f5)] - **tools**: update [email protected] (Rich Trott) [#33072](https://github.com/nodejs/node/pull/33072) | ||
| * [[`8c40ffc329`](https://github.com/nodejs/node/commit/8c40ffc329)] - **tools**: update broken types in type parser (Colin Ihrig) [#33068](https://github.com/nodejs/node/pull/33068) | ||
|
|
||
| <a id="14.1.0"></a> | ||
| ## 2020-04-29, Version 14.1.0 (Current), @BethGriggs | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.