Skip to content

src: don't print garbage errors#4112

Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig:4079
Closed

src: don't print garbage errors#4112
cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig:4079

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 2, 2015

If JS throws an object whose toString() method throws, then Node attempts to print an empty message, but actually prints garbage. This commit checks for this case, and prints a newline instead.

Closes #4079

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants