Skip to content

tools: add eslint rule for __proto__: null in object #48646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rluvaton wants to merge 17 commits into
base: main
Choose a base branch
from
Open

tools: add eslint rule for __proto__: null in object #48646

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f45c225
tools: add eslint rule for __proto__ null in object
rluvaton Jul 3, 2023
361734b
tools: made it fixable
rluvaton Jul 3, 2023
a721c26
tools: made it fixable
rluvaton Jul 3, 2023
94ab2e1
run only for lib files
rluvaton Jul 3, 2023
bb69b0f
fix eslint rule to not support literal proto property
rluvaton Jul 3, 2023
ab4e640
ignore adding proto for the module exports
rluvaton Jul 3, 2023
94e8626
do not add __proto__: null to module.exports
rluvaton Jul 3, 2023
843c110
fix eslint rule to add multiline when needed
rluvaton Jul 4, 2023
68b033b
fix eslint rule for single property object
rluvaton Jul 4, 2023
aafd615
Merge branch 'main' into add-proto-null-in-object-eslint-rule
rluvaton Jul 4, 2023
8726909
fix multiline
rluvaton Jul 4, 2023
db06343
disable proto null for realm to avoid breaking exports
rluvaton Jul 4, 2023
9093d9a
disable proto null for module exports
rluvaton Jul 5, 2023
48625ca
Merge branch 'main' into add-proto-null-in-object-eslint-rule
rluvaton Jul 5, 2023
ccd24d6
update comment
rluvaton Jul 5, 2023
f9cb501
move to multiline the code that keep getting bigger after fix lint
rluvaton Jul 5, 2023
db021f1
run for the entire codebase
rluvaton Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run only for lib files
  • Loading branch information
@rluvaton
rluvaton committed Jul 3, 2023
commit 94ab2e1baf75f1983a8442182a15455f96240147
8 changes: 7 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,13 @@ module.exports = {
},
] },
},
{
files: ['lib/**/*.js', 'lib/**/*.cjs', 'lib/**/*.mjs'],
rules: {
'node-core/set-proto-to-null-in-object': 'error',
},

}
],
rules: {
// ESLint built-in rules
Expand Down Expand Up @@ -316,7 +323,6 @@ module.exports = {
'node-core/no-unescaped-regexp-dot': 'error',
'node-core/no-duplicate-requires': 'error',
'node-core/prefer-proto': 'error',
'node-core/set-proto-to-null-in-object': 'error',
},
globals: {
ByteLengthQueuingStrategy: 'readable',
Expand Down
6 changes: 3 additions & 3 deletions tools/eslint-rules/set-proto-to-null-in-object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ module.exports = {
context.report({
node,
message: 'Every object must have __proto__: null',
fix: function (fixer) {
fix: function(fixer) {
// Generate the fix suggestion to add __proto__: null
const sourceCode = context.getSourceCode();
const firstProperty = properties[0];
const firstPropertyToken = sourceCode.getFirstToken(firstProperty);
const fixText = `__proto__: null, `;
const fixText = '__proto__: null, ';

// Insert the fix suggestion before the first property
return fixer.insertTextBefore(firstPropertyToken, fixText);
Expand All @@ -41,7 +41,7 @@ module.exports = {
context.report({
node,
message: 'Every empty object must have __proto__: null',
fix: function (fixer) {
fix: function(fixer) {
// Generate the fix suggestion to create the object with __proto__: null
const fixText = '{ __proto__: null }';

Expand Down