This repository was archived by the owner on Apr 22, 2023. It is now read-only.
fs.watch error message includes filename#25542
Closed
charlierudolph wants to merge 3 commits intonodejs:masterfrom
charlierudolph:cr-fsWatchError
Closed
fs.watch error message includes filename#25542charlierudolph wants to merge 3 commits intonodejs:masterfrom charlierudolph:cr-fsWatchError
charlierudolph wants to merge 3 commits intonodejs:masterfrom
charlierudolph:cr-fsWatchError
Conversation
test/simple/test-fs-watch-error.js
Outdated
|
Can you open this PR against io.js? Also, if you do that, the 20 line header in the test can be removed. |
Member
|
A new PR against nodejs/node master would be needed at this point. This isn't going to be able to land here. |
cjihrig
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 2, 2015
This commit adds the relevant filename to fs.watch() errors. Refs: nodejs/node-v0.x-archive#25542 PR-URL: #2748 Reviewed-By: Colin Ihrig <[email protected]>
jasnell
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 8, 2015
This commit adds the relevant filename to fs.watch() errors. Refs: nodejs/node-v0.x-archive#25542 PR-URL: #2748 Reviewed-By: Colin Ihrig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the file does not exist or if the file is not accessible (throws EACCES, what I actually ran into) the error thrown did not include the filename.