fix: mason registry verification fails#405
Merged
s1n7ax merged 2 commits intonvim-java:mainfrom Aug 4, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR;
What this PR does is:
In module
java.startup.mason-dep: extracts the code responsible for adding custom registries to Mason frominstallinto a separate functionadd_custom_registries.In module
java: callsmason-dep.add_custom_registriesprior tostartup_checkinsetupLonger explanation:
Pt. 1 is necessary because
startup_checkneeds to be called beforemason-dep.installinjava.setupbut alsomason-dep.installwas adding the registries, so the verification was always going to fail. It allows formason-dep.add_custom_registriesto be called independently.Pt. 2 is necessary because custom registries need to be added before the invalid registry verification for it to succeed.
fixes #403