fix(runner): use argfile for classpath to avoid Windows cmd length limit#470
Open
mKrswe wants to merge 2 commits intonvim-java:mainfrom
Open
fix(runner): use argfile for classpath to avoid Windows cmd length limit#470mKrswe wants to merge 2 commits intonvim-java:mainfrom
mKrswe wants to merge 2 commits intonvim-java:mainfrom
Conversation
Member
|
@mKrswe We for sure don't exceed 8000 args. Was it because of the class path separator is |
Contributor
Author
|
@s1n7ax I am not completely sure to be honest. As of now there are some new comments in the Issue stating that it was a problem with the configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #465
argFile is only used when using Windows and the would be too long.
I also change the classpath seperator to be conditional as Windows is using ';'