Add support for x-enum-varnames to string enums#1358
Merged
dbanty merged 2 commits intoopenapi-generators:mainfrom Mar 10, 2026
Merged
Add support for x-enum-varnames to string enums#1358dbanty merged 2 commits intoopenapi-generators:mainfrom
dbanty merged 2 commits intoopenapi-generators:mainfrom
Conversation
mbbush
force-pushed
the
x-enum-varnames-for-strings
branch
2 times, most recently
from
bed0fdb to
22275fd
Compare
Contributor
Author
|
@dbanty Sorry to have left this for so long, but it looks like there was some CI failure, but I can't see what it is. That might be a permission issue or it might just be because the logs expired months ago. I just rebased off of the latest |
auto-merge was automatically disabled
March 10, 2026 22:25
Head branch was pushed to by a user without write access
mbbush
force-pushed
the
x-enum-varnames-for-strings
branch
2 times, most recently
from
f0202ff to
d087c97
Compare
mbbush
force-pushed
the
x-enum-varnames-for-strings
branch
from
d7df41d to
63da478
Compare
Contributor
Author
|
I configured and ran CI on my fork and was embarrassed to find it was failing because of a silly yaml indentation issue in a multiline string. I must have been running the wrong command when I ran the tests locally. It's fixed now, CI passed on my fork, and seems to be passing here too. |
dbanty
approved these changes
Mar 10, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on #1214, this allows customization of string enumerations in exactly the same way as integer enumerations.