Skip to content

Conversation

@omkarK06
Copy link
Contributor

@omkarK06 omkarK06 commented Dec 11, 2025

#9611
Design at: rum

@github-actions
Copy link
Contributor

Failed to generate code suggestions for PR

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 11, 2025

Greptile Overview

Greptile Summary

Updated RUM dashboard configurations to reflect current Web Vitals standards by replacing the deprecated First Input Delay (FID) metric with Interaction to Next Paint (INP), and adding three new important metrics: First Contentful Paint (FCP), Time to First Byte (TTFB), and Page Load Time.

Key Changes:

  • Replaced view_first_input_delay field with view_interaction_to_next_paint in both dashboard configurations
  • Added three new visualization panels in web_vitals.json for FCP, TTFB, and Page Load Time metrics
  • Adjusted panel layouts to accommodate new metrics (changed panel heights from 8 to 6, added second row with y=8)
  • Updated panel IDs and layout indices to maintain proper grid positioning

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • This is a straightforward configuration update that modernizes the RUM dashboard by replacing deprecated Web Vitals metrics with current standards. The changes are limited to JSON dashboard configuration files with no code logic modifications. All metric field names follow consistent naming patterns, SQL queries are properly structured, and panel layouts are correctly positioned without overlaps
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
web/src/utils/rum/web_vitals.json 5/5 Replaced deprecated FID with INP metric and added three new web vitals panels (FCP, TTFB, Page Load Time) with appropriate layout positioning
web/src/utils/rum/overview.json 5/5 Updated metric panel title and query to use INP instead of deprecated FID

Sequence Diagram

sequenceDiagram
    participant User as User/Browser
    participant RUM as RUM SDK
    participant Dashboard as Dashboard Config
    participant Backend as OpenObserve Backend
    participant DB as _rumdata Stream

    Note over User,DB: Web Vitals Data Collection & Visualization

    User->>RUM: Navigate & Interact with Page
    RUM->>RUM: Collect Web Vitals Metrics<br/>(LCP, INP, CLS, FCP, TTFB, Load Time)
    RUM->>Backend: POST /rum/v1/{org_id}/rum<br/>(view_interaction_to_next_paint,<br/>view_first_contentful_paint, etc.)
    Backend->>DB: Store RUM metrics
    
    Note over Dashboard: Configuration Update (This PR)
    Dashboard->>Dashboard: Update web_vitals.json<br/>- Replace FID → INP<br/>- Add FCP, TTFB, Page Load Time panels
    Dashboard->>Dashboard: Update overview.json<br/>- Replace FID → INP metric

    User->>Dashboard: View RUM Dashboard
    Dashboard->>Backend: Query _rumdata stream<br/>SELECT avg(view_interaction_to_next_paint),<br/>avg(view_first_contentful_paint), etc.
    Backend->>DB: Fetch aggregated metrics
    DB-->>Backend: Return metric data
    Backend-->>Dashboard: Return query results
    Dashboard-->>User: Display Updated Web Vitals<br/>(INP, FCP, TTFB, etc.)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@omkarK06 omkarK06 force-pushed the feat/RUM-improvements-v1 branch from 96a6757 to 292f79c Compare December 11, 2025 12:26
@omkarK06 omkarK06 changed the title feat: Update RUM Web Vitals feat: Updated RUM Web Vitals Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants