Tutorial for Sample memcached#10
Merged
jmrodri merged 2 commits intooperator-framework:mainfrom May 24, 2021
laxmikantbpandhare:sample_memcached
Merged
Tutorial for Sample memcached#10jmrodri merged 2 commits intooperator-framework:mainfrom laxmikantbpandhare:sample_memcached
jmrodri merged 2 commits intooperator-framework:mainfrom
laxmikantbpandhare:sample_memcached
Conversation
tlwu2013
reviewed
May 14, 2021
tlwu2013
reviewed
May 14, 2021
tlwu2013
reviewed
May 14, 2021
Member
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
jmrodri
requested changes
May 15, 2021
Member
jmrodri
left a comment
jmrodri
left a comment
There was a problem hiding this comment.
- Run a spell checker on the file there were quite a few typos
- explain to the user a bit more about what you are doing before showing them the code samples.
- You need to define links that you reference, quite a few broken links
tlwu2013
reviewed
May 18, 2021
Member
Author
Worked on all of the above suggestions. |
tlwu2013
reviewed
May 18, 2021
tlwu2013
reviewed
May 18, 2021
tlwu2013
reviewed
May 18, 2021
jmrodri
reviewed
May 19, 2021
jmrodri
reviewed
May 19, 2021
jmrodri
requested changes
May 19, 2021
Member
jmrodri
left a comment
jmrodri
left a comment
There was a problem hiding this comment.
Did you run these updated commands you have in this doc from scratch? It does not compile looks like there might be a bug in the scaffolder because memcached-quarkus-operator doesn't work.
Make sure you run through this entire doc to make sure all the commands will work and the user gets what you are trying to convey.
There are a few other change requests in the comments as well.
removed DS store files modified sample to testdata added tutorial by considering memcached modified and worked on some of the comment Modified and added few comments. Still working on other review comments modified according to review comments modified link modified according to commnets final changes
jmrodri
approved these changes
May 24, 2021
laxmikantbpandhare
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document for java scaffolding steps by considering memcached-sample-operator.
https://github.com/operator-framework/java-operator-plugins/tree/main/testdata/memcached-quarkus-operator