Unit tests for plugins.go#26
Merged
jmrodri merged 1 commit intooperator-framework:mainfrom Jul 14, 2021
Merged
Conversation
Member
|
Tried locally and working fine. |
Closed
26 tasks
jmrodri
approved these changes
Jul 14, 2021
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package v1 |
Member
There was a problem hiding this comment.
OMG we still have the old package name. This should be v1alpha we should probably rename this in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit tests for v1alpha/init.go
Note: These tests depend on the
v1_suite_test.gotest suite file from this PR: #24.