This repository was archived by the owner on Jan 14, 2018. It is now read-only.
Use generic ABS for mixed-architechture CGFloat#435
Open
fcanas wants to merge 1 commit intoECSlidingViewController:masterfrom
Open
Use generic ABS for mixed-architechture CGFloat#435fcanas wants to merge 1 commit intoECSlidingViewController:masterfrom
fcanas wants to merge 1 commit intoECSlidingViewController:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CGFloatis afloaton 32-bit architectures and adoubleon 64-bit architectures. This makes the use offabsfinappropriate on 64-bit arm. But changing the function tofabswould be inappropriate for 32-bit targets (making #434 incorrect).I propose using the preprocessor macro
ABSto avoid the problem altogether.The reason for such a change is to help the use of this library on projects where strict static analysis is enforced.
A longer, more explicit architecture-dependent approach is also possible.
This may be preferable in cases where the distinct functions are known to have some advantage. However absolute value is a simple enough function that the macro's behavior will be identical.