Replace mentions of swapi.co with swapi.dev#10
Open
bibajz wants to merge 2 commits intophalt:masterfrom
bibajz:master
Open
Replace mentions of swapi.co with swapi.dev#10bibajz wants to merge 2 commits intophalt:masterfrom bibajz:master
bibajz wants to merge 2 commits intophalt:masterfrom
bibajz:master
Conversation
pangolp
reviewed
Aug 27, 2020
pangolp
left a comment
pangolp
left a comment
There was a problem hiding this comment.
Leave 1 question and a recommendation. But I think the pull request would be fine.
|
|
||
| # IDEs | ||
| .idea | ||
| .code No newline at end of file |
There was a problem hiding this comment.
I would add the line break. The rest is fine with me.
| requirements = [ | ||
| 'requests==2.5.0', 'six==1.8.0', 'ujson==1.33' | ||
| ] | ||
| requirements = ['requests', 'six', 'ujson'] |
There was a problem hiding this comment.
Couldn't this generate a conflict in the future if the libraries were updated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library was not functioning with
swapi.settings.BASE_URLset toswapi.co/api.This PR
swapi.cowithswapi.dev0.2.0