[ticket/17621] Change U_WARN to use new warn_allowed variable#6941
Open
kaileymsnay wants to merge 5 commits intophpbb:3.3.xfrom
Open
[ticket/17621] Change U_WARN to use new warn_allowed variable#6941kaileymsnay wants to merge 5 commits intophpbb:3.3.xfrom
kaileymsnay wants to merge 5 commits intophpbb:3.3.xfrom
Conversation
New variable added to allow extensions to force the warn function. PHPBB-17621
|
The attempt to merge branch
A separate PR will be needed to merge |
Prosk8er
reviewed
Mar 9, 2026
phpBB/viewtopic.php
Outdated
| * @var bool force_warn_allowed Allow the user to warn (all permissions and conditions are ignored) | ||
| * @since 3.1.0-b4 | ||
| * @changed 3.1.11-RC1 Added force_softdelete_allowed var | ||
| * @changed 3.1.16-RC1 Added force_warn_allowed var |
Contributor
There was a problem hiding this comment.
3.1.16-RC1? should be 3.3.16-RC1 same in your other PR
Contributor
Author
There was a problem hiding this comment.
Sorry, not sure why I did that. Fixed.
kaileymsnay
force-pushed
the
ticket/17621
branch
from
994013e to
589f286
Compare
PHPBB-17621
kaileymsnay
force-pushed
the
ticket/17621
branch
from
589f286 to
1d791cc
Compare
4 tasks
Contributor
Author
|
Closing PR. This needs more testing to work the way as intended. |
Contributor
Author
|
Re-opening. Newest commit should fix issue. |
rxu
reviewed
Mar 12, 2026
phpBB/viewtopic.php
Outdated
| $permanent_delete_allowed = $force_delete_allowed || ($auth->acl_get('m_delete', $forum_id) || | ||
| ($auth->acl_get('f_delete', $forum_id) && $user->data['user_id'] == $poster_id)); | ||
|
|
||
| $warn_allowed = $force_warn_allowed; |
Contributor
There was a problem hiding this comment.
This assignment looks redundant now, it seems that only 1 var is enough here.
Contributor
Author
There was a problem hiding this comment.
Move it to the U_WARN line? Was trying to stay consistent with edit_allowed and delete_allowed.
kaileymsnay
force-pushed
the
ticket/17621
branch
from
6c60b3c to
4035d37
Compare
PHPBB-17621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPBB-17621
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17621