Skip to content

Conversation

@MauricioFauth
Copy link
Member

No description provided.

@kamil-tekiela
Copy link
Contributor

If it's just a deprecation why are you suppressing it on 5_2? It's not an error.

@MauricioFauth
Copy link
Member Author

If it's just a deprecation why are you suppressing it on 5_2? It's not an error.

When in development mode, deprecations are converted to exceptions, causing some functionalities to not work correctly.

Example from #19837:

before1.mp4

@MauricioFauth
Copy link
Member Author

I'm doing this for these third-party packages only, because they released fixes for these deprecations in newer major versions.
For the strftime function I did it to just remove the @ operator and to suppress only the deprecation.

@kamil-tekiela
Copy link
Contributor

What do you think about making the code not convert deprecations to exceptions? I think the concern is that the deprecation might get burried in the HTML response and go unnoticed, but I don't think that's a problem. On 6.0 branch we can still have them throw, but even then, if they are silenced they can still be forgotten. We could also make the deprecations go away in development altogether.

@williamdes
Copy link
Member

I like the idea, but would rather take it directly to the deprecation error render
and block the render
most users complain because they render
I am unsure if we should throw them in dev mode
but it will be such a pain that we will fix them more quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants