Add handling of self webworker context#48
Merged
pine merged 1 commit intopine:masterfrom Feb 16, 2023
Merged
Conversation
ghost
suggested changes
Feb 12, 2023
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
as I understand it, single quotes please!
| this.cacheable(); | ||
| } | ||
|
|
||
| const request = require.resolve("./to-array-buffer.js"); |
There was a problem hiding this comment.
This repository appears to use single quotes only @wclr
Owner
There was a problem hiding this comment.
Hello @M00TSDNS.
Thank you for your review, and I'm sorry for waiting you.
I will check the Pull Request today.
Owner
|
Hello @wclr. I'm concerned about code style @M00TSDNS also said, but I will fix it after merging this. |
|
It's no worries Pine, hope life is treating you well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47
Formatted with default prettier settings.