Fix blank lines in file-contents-sorter plugin#944
Merged
asottile merged 1 commit intopre-commit:mainfrom Aug 5, 2023
RoelAdriaans:file-content-sorted-blank-line-fix
Merged
Fix blank lines in file-contents-sorter plugin#944asottile merged 1 commit intopre-commit:mainfrom RoelAdriaans:file-content-sorted-blank-line-fix
asottile merged 1 commit intopre-commit:mainfrom
RoelAdriaans:file-content-sorted-blank-line-fix
Conversation
As stated in the documentation: `Note that this hook WILL remove blank lines` Previously this hook would always add blank a blank line. With this fix, if the file is empty, a newline will not be added, and multpline blanklines in a file will be removed. Fixes #935
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in the documentation:
Note that this hook WILL remove blank lines. Previously this hook would always add blank a blank line.With this fix, if the file is empty, a newline will not be added, and multiple blank lines in a file will be removed.
Fixes #935