Decoupling Base.getSketchbookFolder()#1334
Merged
catilac merged 6 commits intoprocessing:mainfrom Nov 26, 2025
Merged
Conversation
catilac
approved these changes
Nov 26, 2025
Collaborator
catilac
left a comment
There was a problem hiding this comment.
This must have been satisfying
Comment on lines
+1
to
+7
| package processing.app | ||
|
|
||
| import kotlin.io.path.createTempDirectory | ||
| import kotlin.test.Test | ||
| import kotlin.test.assertEquals | ||
|
|
||
| class SketchbookTest { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to decouple
Base.getSketchbookFolder()from all its dependenciesPreviously the following was necessary to set up to be able to read the sketchbook folder:
With this PR, one can freely read
Base.getSketchbookFolder()and all of the required initialisation will happen automatically. e.g.It will also clean up the double reference to Processing's language files by just including them in the resources system.
I would prefer to use java's resources going forward and try to move away from the bundled folder.
In general there would need to be a push towards cleaning up the side-effects of a lot of these files but that is very much out of scope for now and this way I can continue building on top of the existing infrastructure.