👍 Thanks. Let's see what Travis does this time.

This'll conflict with my changes I think, as I removed -Werror also. I guess what we really want is to only run -Werror on the newer GHCs though, right? As otherwise this will suffer from the same problem I had.

@garyb I've fixed the only non 7.10 related warning in #1411 so there should be no warnings on earlier versions either(and the travis build for that branch was green for the old versions too, let's see how this one turns out).

Why only run -Werror on the newer GHCs? I think I'd rather have it so that there are no warnings on any of the GHCs that we test with.

Also, sorry I didn't think to mention this earlier, but perhaps base-compat might be a bit nicer than CPP all over the place? I think it would also make it easier to deal with any changes in future base releases, if any situations similar to the Foldable/Traversable Proposal arise in the future.

Both of those sound like good ideas to me.

Why only run -Werror on the newer GHCs? I think I'd rather have it so that there are no warnings on any of the GHCs that we test with.

I've already discovered how painful it is to try and track down warnings by waiting 5-10 minutes for Travis to fail so an import can be tweaked... several times :) It wouldn't be so bad if you got all the errors at once.

Wouldn't base-compat help with that though?

Looks like it, yep!

This needs to be merged with master now, sorry.

Thanks!