Extended parser to accept unicode forall and arrows#1847
Extended parser to accept unicode forall and arrows#1847paf31 merged 1 commit intopurescript:masterfrom DavidLindbom:master
Conversation
There was a problem hiding this comment.
The notFollowedBy is unnecessary for these, no?
There was a problem hiding this comment.
Is ← a unicode symbol character? If so, it's still necessary.
There was a problem hiding this comment.
Oh so you're saying that that may be used as a binding name?
There was a problem hiding this comment.
Yes, since we added unicode operators. @DavidLindbom could you please just verify that something like ←→ can be used as an operator (ideally in a test)?
There was a problem hiding this comment.
Yes they should work, just updated my test.
|
Cool 😄 Could you please update |
|
👍 for this 😄 |
|
Very cool, can't wait for this to get merged. But what about unicode lambda? |
Oh yeah, that'd be nice to have too. |
|
I will take a look at it later. I tried a similar quick fix but |
|
I don't think we need a new lexeme. We can just use |
|
No |
|
Oh, that's a shame. I'm not sure what the best option is, in that case. Perhaps we merge without Another option is to use a space between the In either case, though, I think we can solve this without adding |
|
Related discussion for the same thing in GHC: https://ghc.haskell.org/trac/ghc/ticket/1102 |
|
@paf31 While I still think lambda would fit in to be a lexeme without cluttering it, I also agree that it would be best to revert to the previous commit and discuss later how to solve the lambda problem |
|
Could you please rebase, and I'll get this merged. Thanks. |
|
I'm sorry, by rebase I meant "and squash commits". Could you please do that so we can keep the commit log as simple as possible? |
|
Looks great, thanks! I'll wait for Travis and then get this merged in. |
Extended parser to accept unicode forall and arrows
|
@DavidLindbom Would you be interested in showing this off in 5-10 minutes at the next online meetup? Are you on Twitter? Otherwise I can email. |
I had the same idea. Were there any downsides? |
Saw it was mentioned in #766. This commit should now accept
f ∷ ∀a m. Monad m ⇒ a → m abut also⇐and←in class definition resp. do notation.