Reuse the array returned by match#89
Merged
paf31 merged 1 commit intopurescript:masterfrom Nov 19, 2017
fehrenbach:patch-1
Merged
Reuse the array returned by match#89paf31 merged 1 commit intopurescript:masterfrom fehrenbach:patch-1
paf31 merged 1 commit intopurescript:masterfrom
fehrenbach:patch-1
Conversation
Instead of basically making a copy and letting the original go out of scope immediately after. This makes a surprisingly large performance difference in Chrome, not so much in Firefox.
Contributor
|
This certainly seems safe to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of basically making a copy and letting the original go out of scope immediately after.
This makes a surprisingly large performance difference in Chrome, not so much in Firefox.