resolve: make signature reflect impurity#4
Closed
cstrahan wants to merge 1 commit intopurescript-node:masterfrom
Closed
resolve: make signature reflect impurity#4cstrahan wants to merge 1 commit intopurescript-node:masterfrom
cstrahan wants to merge 1 commit intopurescript-node:masterfrom
Conversation
resolve will return different results depending on the current working directory, so this should be captured in the type signature. Also, simplify the arguments: zero arguments is the same as giving "." as the only argument, so `from` and `to` can be collapsed into one argument.
Member
|
👍 I will merge this manually. |
Member
|
Actually, on second thoughts, I'm not convinced about collapsing |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolvewill return different results depending on the currentworking directory, so this should be captured in the type signature.
Also, simplify the arguments: zero arguments is the same as giving
"."as the only argument, so
fromandtocan be collapsed into oneargument.