Fix callback invocation for readline.question#38
Merged
garyb merged 3 commits intopurescript-node:masterfrom Jun 30, 2024
Merged
Fix callback invocation for readline.question#38garyb merged 3 commits intopurescript-node:masterfrom
garyb merged 3 commits intopurescript-node:masterfrom
Conversation
|
Just a friendly ping for this patch to be merged. Without it, the Readline functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
I've made two small changes to what I think are bugs. The first bug prevents the
questionandquestion'functions from properly invoking the callback they receive, and the second is a small one-character typo in the options passed tocreateInterfaceTo fix the callback not being invoked, I created a
EffectFn1and passed that to the ffi impls. The previous code was passing a function that returned anEffectbut never actually ran that effect.Fixed typo in options passed to createInterface:
s/crlDelay/crlfDelay/Checklist: