bpo-35036: Use empty message as default for logger#10024
Merged
pablogsal merged 2 commits intopython:masterfrom Oct 21, 2018
Merged
bpo-35036: Use empty message as default for logger#10024pablogsal merged 2 commits intopython:masterfrom
pablogsal merged 2 commits intopython:masterfrom
Conversation
Member
Author
|
cc @pablogsal for review |
pablogsal
approved these changes
Oct 21, 2018
Member
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
Thanks for the catch and the PR!
Member
|
I have pushed to your branch removing the logline, as it is not doing anything and can be safely deleted. |
Member
Author
|
Sure, thanks for merging it :) |
Contributor
|
Thanks @tirkarthi for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 8, 2019
…10024) Previous to commit ee171a2 the logline was working because of self.info() (now deprecated) defaults to an empty message. (cherry picked from commit c3f52a5) Co-authored-by: Xtreak <[email protected]>
|
GH-16637 is a backport of this pull request to the 2.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Oct 8, 2019
Previous to commit ee171a2 the logline was working because of self.info() (now deprecated) defaults to an empty message. (cherry picked from commit c3f52a5) Co-authored-by: Xtreak <[email protected]>
gpshead
pushed a commit
to gpshead/cpython
that referenced
this pull request
Sep 2, 2022
…10024) Previous to commit ee171a2 the logline was working because of self.info() (now deprecated) defaults to an empty message.
ned-deily
pushed a commit
that referenced
this pull request
Sep 2, 2022
…GH-96498) Previous to commit ee171a2 the logline was working because of self.info() (now deprecated) defaults to an empty message. Co-authored-by: Xtreak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the change introduced in ee171a2 where
self.info()was replaced withself.logger.info().self.infowas deprecated but it had a default ofmessage=''and the new change also follows the same. I think this is a no-op and can be removed but that is subjected to approval from the reviewer.Original
self.infodefinition :https://bugs.python.org/issue35036