Skip to content

Comments

implement PY_UNSUPPORTED_OPENSSL_BUILD on macOS#100265

Closed
mmomtchev wants to merge 2 commits intopython:mainfrom
mmomtchev:static-ssl-macos
Closed

implement PY_UNSUPPORTED_OPENSSL_BUILD on macOS#100265
mmomtchev wants to merge 2 commits intopython:mainfrom
mmomtchev:static-ssl-macos

Conversation

@mmomtchev
Copy link

@mmomtchev mmomtchev commented Dec 15, 2022 •
edited
Loading

This is an extension for the undocumented and untested (on purpose) feature PY_UNSUPPORTED_OPENSSL_BUILD feature for macOS

This is something that is possible on macOS too via an obscure ld64 linker option called -lhidden-l which specifies that the static library version is to be included and its symbols are not to be reexported.

The macOS ld64 option exists at least since OS X 10.11, but clang supports it only since 15.0.0, hence the -Wl which ensures backwards compatibility

https://releases.llvm.org/15.0.0/tools/lld/docs/ReleaseNotes.html
https://opensource.apple.com/source/ld64/ld64-609/doc/man/man1/ld.1.auto.html

PS Apple's own man-page seems to be slightly misleading - this does not work if both the dynamic and the static libraries are installed at this location - I am still looking for a way to select the static library in this case

@bedevere-bot
Copy link

bedevere-bot commented Dec 15, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@netlify
Copy link

netlify bot commented Dec 15, 2022 •
edited
Loading

✅ Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 284fe16
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/639b1e13e360b50008d5e91d

@ghost
Copy link

ghost commented Dec 15, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

bedevere-bot commented Dec 15, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@encukou
Copy link
Member

encukou commented Apr 10, 2024

Hello,
I see this PR doesn't have an associated issue, and I could find no other discussion.
I don't think we want an undocumented, untested build system feature. I trust the 3 people who added PY_UNSUPPORTED_OPENSSL_BUILD itself (#87632 and #25002), but extending it should come with a similar discussion. (Preferably with a goal to make it supported, even if that'd take a lot of time/effort).

I plan to close the PR in about a month, if there are no objections.

@mmomtchev
Copy link
Author

mmomtchev commented Apr 11, 2024 •
edited
Loading

This PR is two years old and the build system used for 3.12 is not the same anymoore.

Trusting the people is nice, but understanding the changes is even better.

@mmomtchev mmomtchev closed this Apr 11, 2024
@mmomtchev mmomtchev deleted the static-ssl-macos branch April 11, 2024 00:52
@mmomtchev
Copy link
Author

mmomtchev commented Apr 11, 2024

As you may have seen from my profile, I am currently unemployed because of a huge organized extortion with the help of the French police and many big companies. In order to intimidate me, people are posting simultaneous issues on my projects. Yours is one of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmomtchev @bedevere-bot @encukou