[2.7] bpo-3243: Support iterable bodies in httplib#10226
Closed
tzickel wants to merge 1 commit intopython:2.7from
Closed
[2.7] bpo-3243: Support iterable bodies in httplib#10226tzickel wants to merge 1 commit intopython:2.7from
tzickel wants to merge 1 commit intopython:2.7from
Conversation
tzickel
force-pushed
the
itersend
branch
3 times, most recently
from
ca16122 to
3786eb6
Compare
Contributor
Author
|
@orsenthil any chance to get this in? |
Member
|
Hi @tzickel! Unfortunately this didn't get noticed before Python 2.7 reached EOL on January 1st. As this does not appear to be a critical security issue, there is almost no chance that it will be accepted in this brief limbo window between end-of-support and the final 2.7.18 release, so I'm going to go ahead and close it. Thanks for your contribution anyway, and I hope your next one is more fruitful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this is kinda late to the party, but this is not a new functionality API-wise, but a feature parity is required to make HTTP libraries such as requests (and others), be able to send data efficiently.
requests for example uses this piece of code to send the POST data over the HTTP socket if the connection is not chunked. But if the POST data is an iterable object (for example, you want to send the data natively how you stored it, and not split it of read it in 8192 or block chunks), Python 3 works just fine, but Python 2 borks on the sendall(iterable), this fixes this issue...
https://bugs.python.org/issue3243