bpo-30013: Fix compiler warning in Modules/posixmodule.c#1024
Closed
louisom wants to merge 2 commits intopython:masterfrom
louisom:fix_ac_header_major
Closed
bpo-30013: Fix compiler warning in Modules/posixmodule.c#1024louisom wants to merge 2 commits intopython:masterfrom louisom:fix_ac_header_major
louisom wants to merge 2 commits intopython:masterfrom
louisom:fix_ac_header_major
Conversation
Due to glibc 2.25 is deprecating the definition of 'major', 'minor', and 'makedev' by sys/types.h, and autoconf 'AC_HEADER_MAJOR' didn't change it's behavior about this, adding workaround method to prevent compiler warning.
|
@grapherd, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @loewis and @doko42 to be potential reviewers. |
vstinner
reviewed
Oct 17, 2017
| m4_version_prereq([2.70], [], [ | ||
|
|
||
| # This is taken from the following Autoconf patch: | ||
| # http://git.sv.gnu.org/cgit/autoconf.git/commit/?id=XXXXXXX |
Member
There was a problem hiding this comment.
XXXXXXX doesn't seem to be a correct Git sha1 :-)
Member
|
Already fixed in other issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to glibc 2.25 is deprecating the definition of 'major',
'minor', and 'makedev' by sys/types.h, and autoconf
'AC_HEADER_MAJOR' didn't change it's behavior about this,
adding workaround method to prevent compiler warning.