bpo-20596: define a platform dependent Py_WCSTOK in Include/pyport.h,…#10286
Closed
erikjanss wants to merge 4 commits intopython:masterfrom
erikjanss:wcstok
Closed
bpo-20596: define a platform dependent Py_WCSTOK in Include/pyport.h,…#10286erikjanss wants to merge 4 commits intopython:masterfrom erikjanss:wcstok
erikjanss wants to merge 4 commits intopython:masterfrom
erikjanss:wcstok
Conversation
… replace use wcstok with Py_WCSTOK
zooba
reviewed
Nov 3, 2018
Include/pyport.h
Outdated
| * we'll assume that a POSIX-like three-argument version is available. | ||
| */ | ||
| #if defined(MS_WINDOWS) | ||
| # define Py_WCSTOK(str, tok, state) wcstok_s(str, tok, state) |
Member
There was a problem hiding this comment.
Since these are public, but we don't want extenders to rely on them, we should make it _Py_WCSTOK.
Contributor
Author
There was a problem hiding this comment.
Py_WCSTOK was changed to _PyWCSTOK, and NEWS entry was added
Contributor
Author
|
The same issue was handled in bpo-35890 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request based on the patch of Jeffry Armstrong on 2014-02-13,
but discriminating on MS_WINDOWS instead of specific compilers.
https://bugs.python.org/issue20596