bpo-22831: Use "with" to avoid possible fd leaks in distutils.#10921
Merged
serhiy-storchaka merged 1 commit intopython:masterfrom Dec 20, 2018
Merged
bpo-22831: Use "with" to avoid possible fd leaks in distutils.#10921serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka merged 1 commit intopython:masterfrom
Conversation
vstinner
approved these changes
Dec 5, 2018
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
FYI I rebased the PR on master and used "git diff master.. -w" to hide indentation changes.
Member
|
Oh, it's also possible to ignore whitespaces by adding ?w=1 to the URL! |
Member
|
I think this might help in having a review from @merwok given that there is similar open issue with changes to distutils and some comments on the other issue's PR changes https://bugs.python.org/issue35416#msg331114 |
serhiy-storchaka
force-pushed
the
fd-leaks-distutils
branch
from
87e0ff2 to
0741a96
Compare
Member
|
This looks OK. Does it replace the other PR? |
Member
Author
|
It intersects with the other PR. It is an extraction from a larger patch which changed all code that calls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue22831