bpo-35610: IDLE - Replace .context_use_ps1 with .prompt_last_line#11307
Merged
terryjreedy merged 6 commits intopython:masterfrom Jun 2, 2019
Merged
bpo-35610: IDLE - Replace .context_use_ps1 with .prompt_last_line#11307terryjreedy merged 6 commits intopython:masterfrom
terryjreedy merged 6 commits intopython:masterfrom
Conversation
terryjreedy
changed the title
auvipy
approved these changes
Jun 2, 2019
Member
|
@auvipy When you review, please leave a comment that might help me make a decision. I don't know what mere '[x] Approve' means beyond the CI checks passing. |
terryjreedy
changed the title
terryjreedy
requested changes
Jun 2, 2019
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I will make the changes requested and add a couple of comments.
terryjreedy
changed the title
terryjreedy
approved these changes
Jun 2, 2019
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I verified that grepping idlelib recursively for 'context_use_ps1' returns nothing.
Will merge.
terryjreedy
added
needs backport to 3.7
performance
Contributor
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 2, 2019
…thonGH-11307) Changes in bpo- 31858 made the less informative 'context_use_ps1' redundant. (cherry picked from commit 6bdc4de) Co-authored-by: Cheryl Sabella <[email protected]>
|
GH-13747 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 2, 2019
…-11307) Changes in bpo- 31858 made the less informative 'context_use_ps1' redundant. (cherry picked from commit 6bdc4de) Co-authored-by: Cheryl Sabella <[email protected]>
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…thonGH-11307) Changes in bpo- 31858 made the less informative 'context_use_ps1' redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4143 for issue 31858 fixed some uses of the shell prompt and removed setting
context_use_ps1in pyshell, but not in editor. That partial removal was a mistake since the attribute was still used in hyperparser (and some tests). #11346 for issue 34055 reversed the removal. This PR removes both settings of 'context_use_ps1' and replaces all uses with 'prompt_last_line, which is only non-empty in Shell.https://bugs.python.org/issue35610