Skip to content

gh-119146: Update paths in jit.yml #119147

Merged
brandtbucher merged 7 commits intopython:mainfrom
savannahostrowski:jit-ignore-filews
May 19, 2024
Merged

gh-119146: Update paths in jit.yml #119147
brandtbucher merged 7 commits intopython:mainfrom
savannahostrowski:jit-ignore-filews

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented May 18, 2024 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 18, 2024
Closed
@erlend-aasland erlend-aasland requested a review from hugovk May 18, 2024 15:00
@brandtbucher brandtbucher added tests Tests in the Lib/test dir skip news labels May 18, 2024
@brandtbucher brandtbucher self-assigned this May 18, 2024
FFY00
FFY00 approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually be able to ignore Python/perf_jit_trampoline.c by using a negative matching pattern: !Python/perf_jit_trampoline.c.

Other than that, looks good to me.

@savannahostrowski
Copy link
Member Author

savannahostrowski commented May 18, 2024

Oh! I totally didn't know about that. I'll take a look at adding that when I also add .h files to the paths (since I missed adding those in too).

AlexWaygood
AlexWaygood reviewed May 18, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Maybe we could just ignore all .md and .ini files? Then if we added others in the future, we wouldn't have to remember to update this file?

savannahostrowski and others added 2 commits May 18, 2024 15:29
@savannahostrowski @AlexWaygood
Update jit.yml
bf52b3c 
Co-authored-by: Alex Waygood <[email protected]>
@savannahostrowski @AlexWaygood
Update jit.yml
168bfd0 
Co-authored-by: Alex Waygood <[email protected]>
@savannahostrowski
Copy link
Member Author

savannahostrowski commented May 18, 2024

Yeah, that's a fair callout!

AlexWaygood
AlexWaygood approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

brandtbucher
brandtbucher reviewed May 19, 2024
View reviewed changes
@brandtbucher brandtbucher enabled auto-merge (squash) May 19, 2024 12:36
@brandtbucher brandtbucher merged commit 5307f44 into python:main May 19, 2024
@hugovk
Copy link
Member

hugovk commented May 20, 2024

Thanks for the PR!

Shall we backport it, or close the issue?

@erlend-aasland
Copy link
Contributor

erlend-aasland commented May 20, 2024

I think it's ok to backport it to 3.13.

@brandtbucher brandtbucher added the needs backport to 3.13 bugs and security fixes label May 20, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented May 20, 2024

Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@savannahostrowski @AlexWaygood @miss-islington
pythonGH-119146: Don't run JIT CI on unrelated changes (pythonGH-119147)
80ff420 
(cherry picked from commit 5307f44)

Co-authored-by: Savannah Ostrowski <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2024

GH-119226 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2024
This was referenced Jun 12, 2024
Merged
Merged
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@savannahostrowski @AlexWaygood @estyxx
pythonGH-119146: Don't run JIT CI on unrelated changes (pythonGH-119147)
be0335d 
Co-authored-by: Alex Waygood <[email protected]>
@savannahostrowski savannahostrowski deleted the jit-ignore-filews branch September 27, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@FFY00 FFY00 FFY00 approved these changes

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

@brandtbucher brandtbucher

Labels

skip news tests Tests in the Lib/test dir topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@savannahostrowski @hugovk @erlend-aasland @FFY00 @brandtbucher @AlexWaygood